feat: added downloads tracking separate from huggingface#990
Conversation
packages/react-native-executorch/src/utils/ResourceFetcherUtils.ts
Outdated
Show resolved
Hide resolved
8910c17 to
65055ef
Compare
65055ef to
df8b3c7
Compare
f660f17 to
e0211d9
Compare
|
Does this PR closes #612? If so, add |
| * ``` | ||
| * @category Utils | ||
| */ | ||
| export const MODEL_REGISTRY = { |
There was a problem hiding this comment.
Do you think an additional backend layer here would be useful? For now if a model is exported to CoreML, we silently make the user download it. And the user may wish to run the XNNPack model on both platforms for whatever reason.
There was a problem hiding this comment.
I'm fine with this structure to keep it simple for now, but I wonder if it's something we want to add in the future relases.
There was a problem hiding this comment.
I think we should rather have models named LLAMA3_2_3B_XNNPACK etc. than adding another layer of nesting here.
There was a problem hiding this comment.
Just like you said @chmjkb, this is simple for now, I can even remove the type classification (the main reason for this basic registry is that I need it right now to send proper model name to the database) and that might actually be the correct way to go as that would allow us to extend it later without any braking changes/backward compatibility worries.
As for the structure itself, we had a discussion today with Norbert and we didn't reach common ground on the structure so this is still open question and one we should discuss, I think tomorrow in the office is the best option.
ea99afc to
5028267
Compare
Description
Added separate request on model download to track downloads on our managed service. This would allow us to track things like geolocation and have insights on the entire timeline without the need to pay for huggingface premium.
Set up so that it fails silently.
Addtionally added model registry named
MODEL_REGISTRYfor better model discoverability.Introduces a breaking change?
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes